Merged
Conversation
sverhoeven
reviewed
Apr 30, 2021
| from testfixtures import LogCapture | ||
|
|
||
|
|
||
| def test_log_capture(caplog): |
Member
There was a problem hiding this comment.
Can you try to use https://docs.pytest.org/en/6.2.x/logging.html#caplog-fixture instead of another dep
Member
Author
There was a problem hiding this comment.
this function does not exist anymore
sverhoeven
requested changes
Apr 30, 2021
Member
sverhoeven
left a comment
sverhoeven
left a comment
There was a problem hiding this comment.
Can we change example function to
def hello(name):
return f'Hello {name}!'
Member
Author
Updated the function and the test |
Merged
sverhoeven
approved these changes
May 3, 2021
Member
sverhoeven
left a comment
sverhoeven
left a comment
There was a problem hiding this comment.
Nice, I have 100% coverage, hello method is rendered in docs and CI workflow lists tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a test to increase coverage to 100%.